[PATCH] D62439: PGO] Handle cases of failing to split critical edges

[Rong Xu via Phabricator via llvm-commits]

xur marked 7 inline comments as done.
xur added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp:755
+  // Use a worklist as we will update the vector during the iteration.
+  std::vector<Edge *> WorkList;
+  for (auto &E : MST.AllEdges)
----------------
davidxl wrote:
> Nit.  The name 'WorkList' implies it will be updated on the fly -- but here it is the opposite. How about just name it 'EdgeList'
changed to EdgeList.


================
Comment at: llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp:756
+  std::vector<Edge *> WorkList;
+  for (auto &E : MST.AllEdges)
+    WorkList.push_back(E.get());
----------------
grandinj wrote:
> WorkList.reserve(MST.AllEdges.size()) ?
Good idea. Done


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62439/new/

https://reviews.llvm.org/D62439