[lld] r361840 - Fix 'warning: comparison is always true due to limited range of data type [-Wtype-limits]' with GCC 7.3

Alexandre Ganea via llvm-commits llvm-commits at lists.llvm.org
Tue May 28 08:32:11 PDT 2019


Author: aganea
Date: Tue May 28 08:32:11 2019
New Revision: 361840

URL: http://llvm.org/viewvc/llvm-project?rev=361840&view=rev
Log:
Fix 'warning: comparison is always true due to limited range of data type [-Wtype-limits]' with GCC 7.3

Modified:
    lld/trunk/COFF/Chunks.cpp

Modified: lld/trunk/COFF/Chunks.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/COFF/Chunks.cpp?rev=361840&r1=361839&r2=361840&view=diff
==============================================================================
--- lld/trunk/COFF/Chunks.cpp (original)
+++ lld/trunk/COFF/Chunks.cpp Tue May 28 08:32:11 2019
@@ -860,7 +860,7 @@ MergeChunk::MergeChunk(uint32_t Alignmen
 void MergeChunk::addSection(SectionChunk *C) {
   assert(isPowerOf2_32(C->getAlignment()));
   uint8_t P2Align = llvm::Log2_32(C->getAlignment());
-  assert(P2Align >= 0 && P2Align < array_lengthof(Instances));
+  assert(P2Align < array_lengthof(Instances));
   auto *&MC = Instances[P2Align];
   if (!MC)
     MC = make<MergeChunk>(C->getAlignment());




More information about the llvm-commits mailing list