[PATCH] D60707: [ARM] Adjust calling conventions for MVE vectors.

Simon Tatham via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 28 07:41:34 PDT 2019


simon_tatham added a comment.

The problem with the existing NEON calling convention code was that it started by pretending all 128-bit vectors are `v2f64`. But that's the one vector type MVE doesn't have any support for, so there were lots of annoying ISel errors.

Even so, I think you're right that this was the wrong solution. I've managed to get all the tests passing without modifying `ARMCallingConv.td` at all, by the alternative technique of making `v2f64` a legal type in MVE-land even though no actual instructions will usefully operate on one (i.e. everything other than loads and stores are set to `Expand`). I can fold those changes into other patches in this series, so I think this one can be abandoned.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60707/new/

https://reviews.llvm.org/D60707





More information about the llvm-commits mailing list