[PATCH] D62510: [LoopVectorize] Add FNeg instruction support

Cameron McInally via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 28 06:55:46 PDT 2019


cameron.mcinally added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:4011
+      if (UnaryOperator *VecOp = dyn_cast<UnaryOperator>(V))
+        VecOp->copyIRFlags(UnOp);
+
----------------
cameron.mcinally wrote:
> Just posted D62521: Add CreateFNegFMF(...) to the IRBuilder. That should allow you to skip the explicit FMF copy.
Oh, I now see that the BinOperator code above is the generic form too. I don't think there are any other unary operators planned, but it's probably best to keep the UnaryOperator code in line with the BinaryOperator code anyway.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62510/new/

https://reviews.llvm.org/D62510





More information about the llvm-commits mailing list