[PATCH] D60386: FileCheck [6/12]: Introduce numeric variable definition

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre updated this revision to Diff 201649.
thopre marked 2 inline comments as done.
thopre added a comment.

- Split parseNumericVariable into parseNumericVariableUse and parseNumericVariableDefinition since little is shared between two usages of this function
- Change API of parseVariable given that most callers extract the variable name and the trailer from TrailIdx
- Rename CaptureParen into CaptureParenGroup and hopefully clarify what this is about


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60386/new/

https://reviews.llvm.org/D60386

Files:
  llvm/docs/CommandGuide/FileCheck.rst
  llvm/include/llvm/Support/FileCheck.h
  llvm/lib/Support/FileCheck.cpp
  llvm/test/FileCheck/numeric-defines-diagnostics.txt
  llvm/test/FileCheck/numeric-expression.txt
  llvm/test/FileCheck/var-scope.txt
  llvm/test/FileCheck/verbose.txt
  llvm/unittests/Support/FileCheckTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60386.201649.patch
Type: text/x-patch
Size: 70614 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190528/2ab49721/attachment.bin>