[PATCH] D61532: implement of the parsing symbol table for xcoffobjfile and output as yaml format

Digger via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 27 13:28:57 PDT 2019


DiggerLin marked 2 inline comments as done.
DiggerLin added inline comments.


================
Comment at: llvm/lib/Object/XCOFFObjectFile.cpp:111
+  if (SymEntPtr->StorageClass & 0x80)
+    StringRef("Unimplemented Debug Name"); 
+  uint32_t Offset = SymEntPtr->NameInStrTbl.Offset;
----------------
hubert.reinterpretcast wrote:
> hubert.reinterpretcast wrote:
> > Missing "`return`".
> Please fix this.
fixed , thanks a lot


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61532/new/

https://reviews.llvm.org/D61532





More information about the llvm-commits mailing list