[PATCH] D62424: Tests for nosync function attribute.

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 27 10:58:04 PDT 2019


jdoerfert added a comment.

In D62424#1517471 <https://reviews.llvm.org/D62424#1517471>, @sstefan1 wrote:

> Addressed most of the comments.
>
> In D62424#1517384 <https://reviews.llvm.org/D62424#1517384>, @jdoerfert wrote:
>
> > a positive and a negative test with `volatile` would be good.
>
>
> What can be the positive case for SCC tests with volatile? Isn't volatile always supposed to sync?


Good point. Ignore that part.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62424/new/

https://reviews.llvm.org/D62424





More information about the llvm-commits mailing list