[PATCH] D60762: [SelectionDAG] Legalize vaargs that require vector splitting

Luke Lau via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 27 09:03:51 PDT 2019


luke marked 2 inline comments as done.
luke added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:1858
+  Lo = DAG.getVAArg(NVT, dl, Chain, Ptr, SV, Align);
+  Hi = DAG.getVAArg(NVT, dl, Lo.getValue(1), Ptr, SV, 0);
+  Chain = Hi.getValue(1);
----------------
shchenz wrote:
> Why `vaarg` has alignment `0`? I think it should be the result of `getABITypeAlignment()` for type of `Hi`? and also the alignment for `Lo` should not be right.
Updated: I presume they should both have the same alignment?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60762/new/

https://reviews.llvm.org/D60762





More information about the llvm-commits mailing list