[PATCH] D62353: [cmake] Add new LLVM_CACHE_VARIABLES variable to contains all variables passed to cmake on the commandline or in cache files.

Don Hinton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 27 07:41:40 PDT 2019


hintonda added a comment.

I’m not sure printing out the entire CMakeCache.txt file is a good idea — it’s huge and much of it is of no interest.

However, a subset including all the project specific variables would be great.  The good, or bad, depending on your perspective, is that the cache file isn’t available until processing is complete.  So we’d still need to iterate over all variables as a last step in say llvm/CMakeLists.txt.

Perhaps noting default value and whether or not it’s in the cache.  To facilitate that, I’d like to try to wrap option in llvm_option and save the default to the cache as well.  This would also make it easy for maintainers to do the right thing and remove a lot of boilerplate from the cmake files.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62353/new/

https://reviews.llvm.org/D62353





More information about the llvm-commits mailing list