[PATCH] D62062: [DWARF][RISCV] Add support for RISC-V relocations needed for debug info

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: test/DebugInfo/RISCV/dwarf-riscv-relocs.ll:2
+; RUN: llc -filetype=obj -mtriple=riscv32 -mattr=+relax %s -o %t.o
+; RUN: llvm-objdump -r %t.o | FileCheck -check-prefix=OBJDUMP-RELOCS %s
+; RUN: llvm-objdump -source %t.o | FileCheck -check-prefix=OBJDUMP-SOURCE %s
----------------
`llvm-readobj -r` instead of `llvm-objdump -r`. objdump is not suitable for various non-disassembly tasks because its format is weird.


================
Comment at: test/DebugInfo/RISCV/dwarf-riscv-relocs.ll:99
+!5 = !{i32 1, !"wchar_size", i32 4}
+!6 = !{!"clang version 9.0.0 (https://github.com/llvm-mirror/clang.git b30c81b061a542e85b98e3d337050a9b5170db80) (https://github.com/llvm-mirror/llvm.git 43400b1e8f0f6991bb86ca25310a8058a3d0ce79)"}
+!7 = distinct !DISubprogram(name: "main", scope: !1, file: !1, line: 1, type: !8, scopeLine: 2, spFlags: DISPFlagDefinition, unit: !0, retainedNodes: !2)
----------------
This ident info may be replaced with something else..


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62062/new/

https://reviews.llvm.org/D62062