[PATCH] D62439: PGO] Handle cases of failing to split critical edges

Noel Grandin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 26 00:02:30 PDT 2019


grandinj added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp:750
 
+// Collect all the BBs that will be instuments and return them in InstrumentBBs.
+template <class Edge, class BBInfo>
----------------
instuments -> instrumented


================
Comment at: llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp:756
+  std::vector<Edge *> WorkList;
+  for (auto &E : MST.AllEdges)
+    WorkList.push_back(E.get());
----------------
WorkList.reserve(MST.AllEdges.size()) ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62439/new/

https://reviews.llvm.org/D62439





More information about the llvm-commits mailing list