[PATCH] D62153: [WebAssembly] Relax signature checking for undefined functions that are not called directly

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 24 15:31:39 PDT 2019


sbc100 added inline comments.


================
Comment at: lld/wasm/InputFiles.cpp:280
     if (Section.Type == WASM_SEC_CODE) {
+      assert(!CodeSection);
       CodeSection = &Section;
----------------
dschuff wrote:
> Since this is a validation of external input, should we use `report_fatal_error` or some equivalent instead of assert?
This should already have been validated by libObject so I think this is ok .g


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62153/new/

https://reviews.llvm.org/D62153





More information about the llvm-commits mailing list