[PATCH] D62249: RegAllocFast: Set MayLiveAcrossBlocks when allocating uses

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 24 15:26:21 PDT 2019


qcolombet added inline comments.


================
Comment at: lib/CodeGen/RegAllocFast.cpp:297
+  if (MayLiveAcrossBlocks.test(TargetRegisterInfo::virtReg2Index(VirtReg)))
+    return true;
+
----------------
arsenm wrote:
> qcolombet wrote:
> > We should return `!MBB->pred_empty()`
> Does it matter for an unreachable block?
It could be the entry block, couldn't it?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62249/new/

https://reviews.llvm.org/D62249





More information about the llvm-commits mailing list