[PATCH] D62422: [COFF] Add ImportChunkThunk, simplify, deduplicate
Alexandre Ganea via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 24 14:18:53 PDT 2019
aganea accepted this revision.
aganea added a comment.
This revision is now accepted and ready to land.
Looks good, thanks!
================
Comment at: lld/COFF/Chunks.h:177
protected:
- NonSectionChunk() : Chunk(OtherKind) {}
+ NonSectionChunk(Kind K = OtherKind) : Chunk(K) {}
};
----------------
Not a big deal, you could have said `using Chunk::Chunk` to not duplicate the behavior.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62422/new/
https://reviews.llvm.org/D62422
More information about the llvm-commits
mailing list