[PATCH] D59666: AMDGPU: RETURNADDR lowering

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: returnadr.diff:2
+diff --git a/lib/Target/AMDGPU/SIISelLowering.cpp b/lib/Target/AMDGPU/SIISelLowering.cpp
+index c2cda5ef4d7..a59b54902b2 100644
+--- a/lib/Target/AMDGPU/SIISelLowering.cpp
----------------
You somehow added the diff as a file


================
Comment at: returnadr.diff:105
++entry:
++  %tmp = tail call i8* @llvm.returnaddress(i32 1)
++  br label %exit
----------------
The call is still in the entry block. You should also make it a conditional branch to make sure nothing folds it


================
Comment at: test/CodeGen/AMDGPU/returnaddress.ll:42-43
+entry:
+  %tmp = tail call i8* @llvm.returnaddress(i32 1)
+  br label %exit
+
----------------
The call is still in the entry block. You should also make it a conditional branch to make sure nothing folds it


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59666/new/

https://reviews.llvm.org/D59666