[PATCH] D62408: [X86] Avoid SFB - Fix inconsistent codegen with/without debug info(2)

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/lib/Target/X86/X86AvoidStoreForwardingBlocks.cpp:345
        PBInst != E; ++PBInst) {
+    if (PBInst->isDebugInstr())
+      continue;
----------------
Do you perhapswant to use `isMetaInstruction()` here? There are other non-debug instructions (CFI for example) that you might want to ignore.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62408/new/

https://reviews.llvm.org/D62408