[PATCH] D62311: [LV] Inform about exactly reason of loop illegality

Hideki Saito via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 24 11:08:15 PDT 2019


hsaito added a comment.

In D62311#1516399 <https://reviews.llvm.org/D62311#1516399>, @psamolysov wrote:

> @hsaito I agree, to have a function to report about an error is a good idea.
>
> I'm new in LLVM community, so what does NFC mean? Should I close this review and open a new one or you mean just to upload a new diff for comments?


NFC stands for Non Functional Change. No, your review is good here. I'm just throwing an idea for another separate patch, trying to get other people's opinion,
while I was thinking why LLVM_DEBUG wasn't added here when ORE->emit was added.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62311/new/

https://reviews.llvm.org/D62311





More information about the llvm-commits mailing list