[PATCH] D62317: [llvm-objcopy] - Strip undefined symbols if they are no longer referenced following --only-section

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 24 07:35:19 PDT 2019


grimar marked an inline comment as done.
grimar added inline comments.


================
Comment at: test/tools/llvm-objcopy/ELF/only-section-strip-undefined.test:1
+## Here we want to check that llvm-objcopy removes an undefined symbol
+## if all references to it have been stripped.
----------------
jhenderson wrote:
> jhenderson wrote:
> > Maybe worth removing "only-section" from the test title, as I think it would make sense for other options to fall under this test too.
> Since this looks to be only for -j behaviour, don't do this after all.
:) I updated a few seconds before your comment. Will upload a new diff in a minute.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62317/new/

https://reviews.llvm.org/D62317





More information about the llvm-commits mailing list