[PATCH] D62317: [llvm-objcopy] - Strip undefined symbols if they are no longer referenced following --only-section

[George Rimar via Phabricator via llvm-commits]

grimar updated this revision to Diff 201172.
grimar marked an inline comment as done.
grimar added a comment.

- Addressed review comments.

> The behaviour you've implemented removes all unreferenced symbols, even if they weren't previously referenced.

Is this wise?

This behavior follows GNU, i think it is probably OK. Do you think we should change it?

> Also, have you experimented with other stripping options, e.g. removing a section which references a symbol?
>  The bug used --only-section, but there might be other similar cases.

Not yet, but that was my plan (after landing this). I was not going to close the bug before testing
other options and fixing them (I expect to see issues, yes).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62317/new/

https://reviews.llvm.org/D62317

Files:
  test/tools/llvm-objcopy/ELF/only-section-strip-undefined.test
  tools/llvm-objcopy/ELF/ELFObjcopy.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62317.201172.patch
Type: text/x-patch
Size: 3691 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190524/80c9260e/attachment.bin>