[PATCH] D62326: [ARM] Select a number of fp16 rounding functions

[Dave Green via Phabricator via llvm-commits]

dmgreen marked an inline comment as done.
dmgreen added inline comments.


================
Comment at: llvm/test/CodeGen/ARM/fp16-full.ll:491
 
-; FIXME
-;define void @test_floor(half* %p) {
-;  %a = load half, half* %p, align 2
-;  %r = call half @llvm.floor.f16(half %a)
-;  store half %r, half* %p
-;  ret void
-;}
+define void @test_floor(half* %p) {
+; CHECK-LABEL: test_floor:
----------------
SjoerdMeijer wrote:
> There's a TODO in `fp16-instructions.ll` for these instructions. Either move the test there, or remove the TODOs.
Oh yeah. I think I saw that file and decided it was too messy and was trying to do too much. I really needed something that could auto-generate the tests.

There is also fp16-promote.ll which is where a lot of these tests came from and seemed a lot cleaner. Ideally neither of these tests would require loading from half pointers or the float coerce thing, which would make them cleaner still.

Anyway. I'll remove the TODO's, seeing as they are covered elsewhere.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62326/new/

https://reviews.llvm.org/D62326