[PATCH] D62360: [X86] Add zero idioms to the haswell, broadwell, and skylake schedule models. Add 256-bit fp xor to sandybridge zero idioms

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 24 02:38:56 PDT 2019


courbet accepted this revision.
courbet added a comment.
This revision is now accepted and ready to land.

Thanks.



================
Comment at: llvm/lib/Target/X86/X86SchedSandyBridge.td:1163
     SchedVar<MCSchedPredicate<ZeroIdiomPredicate>, [SBWriteZeroLatency]>,
-    SchedVar<NoSchedPred,                          [SBWriteResGroup30]>
+    SchedVar<NoSchedPred,                          [SBWritePCMPGTQ]>
 ]>;
----------------
craig.topper wrote:
> I didn't like the reference to ResGroup30 since someone could easily rearrange numbers and not know this was dependent. So I copied the class and gave it a better name.
Makes sense.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62360/new/

https://reviews.llvm.org/D62360





More information about the llvm-commits mailing list