[PATCH] D62342: [SelectionDAG] Enhance the simplification of `copyto` from `implicit-def`.

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 24 00:48:51 PDT 2019


nhaehnle requested changes to this revision.
nhaehnle added a comment.
This revision now requires changes to proceed.

I don't think this is correct. If an IMPLICIT_DEF has multiple uses, then the correctness of the program may depend on all uses seeing the same value, even if that value is undefined.

The description also doesn't line up with the test description (which talks about making sure that something doesn't crash).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62342/new/

https://reviews.llvm.org/D62342





More information about the llvm-commits mailing list