[PATCH] D62364: llvm-objcopy: Implement --extract-partition and --extract-main-partition.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 23 20:12:08 PDT 2019


MaskRay added inline comments.


================
Comment at: llvm/tools/llvm-objcopy/ELF/Object.cpp:961
+
+  for (auto &Section : Obj.sections()) {
+    if (Section.Type == SHT_LLVM_PART_EHDR &&
----------------
`const SectionBase &`. Recently there were changes to spell `auto` types explicitly.


================
Comment at: llvm/tools/llvm-objcopy/ObjcopyOpts.td:152
+def extract_main_partition
+    : Flag<["-", "--"], "extract-main-partition">,
+      HelpText<"Extract main partition from the input file">;
----------------
`Flag<["--"]`. In llvm-objcopy land, we no longer use `-long-option`...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62364/new/

https://reviews.llvm.org/D62364





More information about the llvm-commits mailing list