[PATCH] D62327: [X86][CodeGen][NFC] Delay `combineIncDecVector()` from DAGCombine to X86DAGToDAGISel

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 23 13:35:10 PDT 2019


craig.topper added inline comments.


================
Comment at: lib/Target/X86/X86ISelDAGToDAG.cpp:3449
+  APInt SplatVal;
+  if (!X86::isConstantSplat(OneVec, SplatVal) || !SplatVal.isOneValue())
+    return false;
----------------
What happens to the constant pool value we already allocated. Does something recognize that is unused and not emit to the final assembly?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62327/new/

https://reviews.llvm.org/D62327





More information about the llvm-commits mailing list