[PATCH] D62338: [globalisel][legalizer] Combine G_TRUNC+G_MERGE_VALUES in artifact combiner

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/LegalizationArtifactCombiner.h:348
+        markInstAndDefDead(MI, *DefMI, DeadInsts);
+        return true;
+      } else if (DstTy.isScalar() && OriginTy.isScalar() &&
----------------
No else after return


================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/LegalizationArtifactCombiner.h:349
+        return true;
+      } else if (DstTy.isScalar() && OriginTy.isScalar() &&
+                 DstTy.getSizeInBits() < OriginTy.getSizeInBits()) {
----------------
Aren't these both required to be scalars anyway? If a vector is involved you have to use G_CONCAT_VECTOR or G_BUILD_VECTOR


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62338/new/

https://reviews.llvm.org/D62338