[PATCH] D62296: [Object] object::ELFObjectFile::symbol_begin(): skip symbol index 0
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 23 08:34:08 PDT 2019
jhenderson added a comment.
Have you made sure that there aren't any uses which would result in an undesired change in behaviour because of this? I feel like it's something that people wouldn't expect to change, and therefore wouldn't test explicitly necessarily.
There should also be a test case somewhere (not that I have a good suggestion for where).
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62296/new/
https://reviews.llvm.org/D62296
More information about the llvm-commits
mailing list