[PATCH] D62319: IR: add 'size <N>' attribute to 'byval' function parameters

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 23 08:04:24 PDT 2019


dblaikie added a comment.

Hey Tim - thanks for looking into this!

The original discussions for this had centered around adding a parameter to the byval attribute itself, rather than having it dependent on another attribute.

In the typeless pointer future - this size attribute wouldn't be optional, but required when 'byval' is present. So this seems more like a transitionary state - and perhaps we should consider whether the intermediate state is worthwhile compared to what would be the final form.

ie: What about adding an integer parameter to 'byval'?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62319/new/

https://reviews.llvm.org/D62319





More information about the llvm-commits mailing list