[PATCH] D62084: Fix DWARF DebugInfo unit test errors when cross-compiling

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 23 07:40:59 PDT 2019


probinson added a comment.

Looks like the right solution, but have you actually tried it with an empty default triple?



================
Comment at: llvm/unittests/DebugInfo/DWARF/DwarfUtils.cpp:28
 
-Triple llvm::dwarf::utils::getHostTripleForAddrSize(uint8_t AddrSize) {
-  Triple T(Triple::normalize(LLVM_HOST_TRIPLE));
+Triple llvm::dwarf::utils::getDefaultTargetTripleForDefaultAddrSize() {
+  // There are cases where the LLVM_DEFAULT_TARGET_TRIPLE may be empty, so
----------------
I think `getDefaultTargetTriple` would be a better name here.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62084/new/

https://reviews.llvm.org/D62084





More information about the llvm-commits mailing list