[PATCH] D62249: RegAllocFast: Set MayLiveAcrossBlocks when allocating uses

Brooks Moses via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 22 11:50:48 PDT 2019


brooksmoses added a comment.

Thanks for the quick fix for bug 41973!



================
Comment at: lib/CodeGen/RegAllocFast.cpp:295
+/// Returns false if \p VirtReg is known to not be live into the current block.
+bool RegAllocFast::mayLiveIn(unsigned VirtReg) {
+  if (MayLiveAcrossBlocks.test(TargetRegisterInfo::virtReg2Index(VirtReg)))
----------------
Are you expecting future uses of this to want to use the return value?  Looks like it's currently unused, and removing it would simplify some things.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62249/new/

https://reviews.llvm.org/D62249





More information about the llvm-commits mailing list