[PATCH] D62255: [llvm-objdump] Improve testing of some switches #3

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht accepted this revision.
rupprecht added a comment.
This revision is now accepted and ready to land.

btw, a common tag I see in titles for a patch like this is `[test]` since you aren't touching any code. I should have mentioned that for the previous patches...

Just a few minor comments



================
Comment at: test/tools/llvm-objdump/X86/disasm-specific-funcs-mangled-name.test:6
+# RUN: llvm-objdump -d --disassemble-functions=_Z3foov %t.o | FileCheck %s
+# RUN: llvm-objdump -d --disassemble-functions=foo() %t.o | FileCheck %s --check-prefix=NOFOO
+# RUN: llvm-objdump -d -C --disassemble-functions=foo() %t.o | FileCheck %s --check-prefix=NOFOO
----------------
`--disassemble-functions=foo()` should be single quoted to handle (), e.g.

```
$ echo foo()
bash: syntax error near unexpected token `('
```


================
Comment at: test/tools/llvm-objdump/X86/elf-disasm-dynamic-symbols.test:10
+## they meet the necessary criteria.
+# RUN: llvm-objcopy --strip-all %t %t2
+# RUN: llvm-objdump -d %t2 | FileCheck %s --check-prefixes=CHECK,DYN
----------------
nit: use llvm-strip in-place (no `%t2`)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62255/new/

https://reviews.llvm.org/D62255