[PATCH] D62256: [llvm-readobj] Implement GNU-style output for dynamic table

Wed May 22 08:21:45 PDT 2019

MaskRay added a comment.

I think the header row is apparently misaligned. Not sure we want to misalign ourselves...

  % ~/projects/binutils-gdb/Debug/binutils/readelf -d =cat

  Dynamic section at offset 0x7df8 contains 26 entries:
    Tag        Type                         Name/Value
   0x0000000000000001 (NEEDED)             Shared library: [libc.so.6]
   0x000000000000000c (INIT)               0x15a0      

Regarding the extra parentheses, I am not sure if we really want to make llvm-readelf/llvm-readobj different just to become more readobj-like, but I'd like to hear what others say.

================
Comment at: llvm/test/tools/llvm-readobj/elf-dynamic-tags-machine-specific.test:123
+# GNU-MIPS-NEXT:   0x000000007000002c (MIPS_INTERFACE_SIZE)0x10
+# GNU-MIPS-NEXT:   0x000000007000002d (MIPS_RLD_TEXT_RESOLVE_ADDR)0x8
+# GNU-MIPS-NEXT:   0x000000007000002e (MIPS_PERF_SUFFIX)   0x0
----------------
`(MIPS_RLD_TEXT_RESOLVE_ADDR)0x8`

This missing space separator definitely looks weird. What does GNU readelf do?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62256/new/

https://reviews.llvm.org/D62256