[PATCH] D62253: [objdump] Dump inline relocations if the relocated section is specified with --section

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 22 07:10:45 PDT 2019


grimar added a comment.

This looks good (with my comment addressed :) But please wait unil anyone else also take a look.



================
Comment at: tools/llvm-objdump/llvm-objdump.cpp:932
       V.push_back(R);
-    // Sort relocations by address.
     llvm::sort(V, isRelocAddressLess);
   }
----------------
This part contains unneseccary variable renamings and also a comment removal.
I would keep the old style.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62253/new/

https://reviews.llvm.org/D62253





More information about the llvm-commits mailing list