[PATCH] D62188: Speed up --start-lib and --end-lib.

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

> With this patch: 5.674s (+0.0%)
>  Withtout this patch: 6.087s (+7.2%)
>  Original: 5.886s (+3.7%)

Can it be that you are running debug LLD? I think linking clang was much faster in the past.



================
Comment at: lld/ELF/InputFiles.cpp:919
 
+// Initialize this->Symbols. this->Symbols is a parallel array as
+// its corresponding ELF symbol table.
----------------
Did you use `this->` intentionally in the comments? I think just `Symbols` would look better.


================
Comment at: lld/ELF/InputFiles.cpp:927
+  if (this->Symbols.empty())
+    this->Symbols.resize(ESyms.size());
+
----------------
What is wrong with calling resize without check? It should do nothing I think.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62188/new/

https://reviews.llvm.org/D62188