[PATCH] D62188: Speed up --start-lib and --end-lib.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/ELF/InputFiles.cpp:995
+    }
 
     fatal(toString(this) + ": unexpected binding: " + Twine((int)Binding));
----------------
ruiu wrote:
> MaskRay wrote:
> > Missing `default:`
> Does this have to be exhaustive? We have a `fatal` after this switch. Anyways, I think I can rewrite this with `if`.
It doesn't have to be exhaustive. I thinkg `-Wswitch-enum` doesn't fire if the variable (`Binding`) is not of the enum type. I find the original switch easier to read...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62188/new/

https://reviews.llvm.org/D62188