[PATCH] D62072: [llvm-objcopy]Tidy up error messages

Jordan Rupprecht via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 21 17:36:24 PDT 2019


rupprecht accepted this revision.
rupprecht added a comment.

This is a super-nit, but the title should have a space, i.e. `[llvm-objcopy] Tidy ...`

LGTM modulo that and the clang-format thing James mentioned



================
Comment at: llvm/tools/llvm-objcopy/ELF/ELFObjcopy.cpp:254
   };
-  if (Error E = DWOFile->removeSections(Config.AllowBrokenLinks,
-                                        OnlyKeepDWOPred))
+  if (Error E =
+          DWOFile->removeSections(Config.AllowBrokenLinks, OnlyKeepDWOPred))
----------------
jhenderson wrote:
> abrachet wrote:
> > clang-format did this but I think the previous one looks better
> I'd revert it, since this isn't related to your change (see above comment).
Specifically, `git-clang-format` handles this well. Editors can also usually be configured for this, depending on which one you use.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62072/new/

https://reviews.llvm.org/D62072





More information about the llvm-commits mailing list