[PATCH] D62210: [WebAssembly] Implement __builtin_return_address for emscripten

Guanzhong Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 21 14:35:21 PDT 2019


quantum marked an inline comment as done.
quantum added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:994
+  if (verifyReturnAddressArgumentIsConstant(Op, DAG))
+    return SDValue();
+
----------------
aheejin wrote:
> Does this mean we ignore the whole node if the argument is not a constant? How about signaling a failure?
`verifyReturnAddressArgumentIsConstant` takes care of generating the error. This code is copied from what other targets are doing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62210/new/

https://reviews.llvm.org/D62210





More information about the llvm-commits mailing list