[PATCH] D62215: Fixes to distribution example for X86_64 Arch Linux

Chris Bieneman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 21 14:16:01 PDT 2019


beanz added a comment.

Adding "libcxxabi" to `LLVM_ENABLE_RUNTIMES` is fine, but the other changes to the DistributionExample are only needed because you chose to use gold, which is a configuration-specific decision that is not representative of how most people will build, therefore it shouldn't be in the example.

I'm also not sure the `PLUGIN_TOOL` line is correct. That seems to assume that you either set `LLVM_ENABLE_LLVM_DYLIB`, or have libLLVM pre-installed, which I don't think most people do.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62215/new/

https://reviews.llvm.org/D62215





More information about the llvm-commits mailing list