[PATCH] D61887: [SelectionDAG] computeKnownBits - support constant pool values from target

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 21 14:01:52 PDT 2019


craig.topper added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:5777
 
   auto *CNode = dyn_cast<ConstantPoolSDNode>(Ptr);
   if (!CNode || CNode->isMachineConstantPoolEntry() || CNode->getOffset() != 0)
----------------
Is there an implicit assumption here that constant pool loads won't be a SEXTLOAD/ZEXTLOAD/EXTLOAD? If they were we'd get a mismatch of bitwidth right?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61887/new/

https://reviews.llvm.org/D61887





More information about the llvm-commits mailing list