[PATCH] D62210: [WebAssembly] Implement __builtin_return_address for emscripten

[Thomas Lively via Phabricator via llvm-commits]

tlively added inline comments.


================
Comment at: llvm/test/CodeGen/WebAssembly/return-address-emscripten.ll:6
+
+; This tests the implementation of __builtin_return_address on emscripten
+; CHECK-LABEL: test_returnaddress:
----------------
Please add a newline after the explanatory comment to visually separate it from the CHECK lines.


================
Comment at: llvm/test/CodeGen/WebAssembly/return-address-unknown.ll:2
+; RUN: llc < %s -asm-verbose=false 2>&1
+; XFAIL: *
+
----------------
It would be better to pipe the error message to FileCheck and Check for the exact message you are expecting, rather than to just expect the test as a whole to fail.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62210/new/

https://reviews.llvm.org/D62210