[PATCH] D62210: [WebAssembly] Implement __builtin_return_address for emscripten

[Thomas Lively via Phabricator via llvm-commits]

tlively added inline comments.


================
Comment at: llvm/test/CodeGen/WebAssembly/return-address.ll:6
+
+; CHECK-LABEL: return_test:
+; CHECK-NEXT: .functype return_test () -> (i32){{$}}
----------------
Can you add a comment to this test saying what it is for? Also, it would be good to add a test to check for an error on wasm32-unknown-unknown.


================
Comment at: llvm/test/CodeGen/WebAssembly/return-address.ll:11
+; CHECK-NEXT: {{^}} end_function{{$}}
+define i8* @return_test() {
+  %r = call i8* @llvm.returnaddress(i32 0)
----------------
how about naming this `test_returnaddress` to call attention to what's being tested.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62210/new/

https://reviews.llvm.org/D62210