[PATCH] D61711: [ELF][Driver] Fix precedence of symbol ordering file and CGProfile

Tue May 21 09:08:38 PDT 2019

tcwang added a comment.

In D61711#1509397 <https://reviews.llvm.org/D61711#1509397>, @MaskRay wrote:

> The commit description of rLLD361190 <https://reviews.llvm.org/rLLD361190> does not contain `Differential Revision: https://reviews.llvm.org/D61711`, so the revision was not closed when you committed that...
>
> Also, the description should probably say the two options are now exclusive:
>
> > (1) When both --symbol-ordering-file=<file> and --call-graph-order-file=<file> are present, whichever flag comes later will take precedence.

Thank you! I'll keep in mind to add the differential revision to LLVM commit next time. Also, is it possible to change the commit message on the other commits now? Sorry that I forgot to change them...

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61711/new/

https://reviews.llvm.org/D61711