[PATCH] D62179: [llvm-readelf] - Allow dumping of the .dynamic section even if there is no PT_DYNAMIC header.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

This is an odd situation anyway (unless you know of a concrete example), so I don't think any users are likely to hit it either way. I don't think we need to follow GNU's behaviour here as a result. We should just do what makes the most sense (and GNU's behaviour doesn't make much sense to me). It would be worth getting somebody else's opinion on this too.



================
Comment at: tools/llvm-readobj/ELFDumper.cpp:1363-1364
+
+  // If we have a PT_DYNAMIC header, we might want either check the dynamic
+  // section found or take the dynamic table data directly from the header. We
+  // do not want to do anything else otherwise.
----------------
might want -> will
the dynamic section found -> the found dynamic section

I don't think you need the last sentence.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62179/new/

https://reviews.llvm.org/D62179