[PATCH] D62191: [SelectionDAG] define binops as a superset of commutative binops

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 21 06:00:41 PDT 2019


spatel created this revision.
spatel added reviewers: RKSimon, craig.topper, lebedev.ri.
Herald added a subscriber: mcrosier.
Herald added a project: LLVM.

The test diffs show improved vector narrowing for integer min/max opcodes because those were all absent from the list. I'm not sure if we can expose functional diffs for all of the moved/added opcodes though.

It seems like we are missing an AVX512 opportunity to use 256-bit ops in place of 512-ops on some tests/targets, but I think that can be a follow-up.


https://reviews.llvm.org/D62191

Files:
  llvm/include/llvm/CodeGen/TargetLowering.h
  llvm/test/CodeGen/X86/horizontal-reduce-smax.ll
  llvm/test/CodeGen/X86/horizontal-reduce-smin.ll
  llvm/test/CodeGen/X86/horizontal-reduce-umax.ll
  llvm/test/CodeGen/X86/horizontal-reduce-umin.ll
  llvm/test/CodeGen/X86/vector-reduce-smax-widen.ll
  llvm/test/CodeGen/X86/vector-reduce-smax.ll
  llvm/test/CodeGen/X86/vector-reduce-smin-widen.ll
  llvm/test/CodeGen/X86/vector-reduce-smin.ll
  llvm/test/CodeGen/X86/vector-reduce-umax-widen.ll
  llvm/test/CodeGen/X86/vector-reduce-umax.ll
  llvm/test/CodeGen/X86/vector-reduce-umin-widen.ll
  llvm/test/CodeGen/X86/vector-reduce-umin.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62191.200471.patch
Type: text/x-patch
Size: 84016 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190521/cadbaea2/attachment.bin>


More information about the llvm-commits mailing list