[PATCH] D62166: [mips] Always check that `shift and add` optimization is efficient

Miloš Stojanović via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 21 05:06:42 PDT 2019


mstojanovic added inline comments.


================
Comment at: llvm/lib/Target/Mips/MipsSEISelLowering.cpp:768-769
 
+  if (Steps > MaxSteps)
+    return false;
+
----------------
You could also move this as the first thing in the while block which removes the `Steps <= MaxSteps` check.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62166/new/

https://reviews.llvm.org/D62166





More information about the llvm-commits mailing list