[PATCH] D62063: CMake changes to get Windows self-host with PGO working

Russell Gallop via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 21 03:05:52 PDT 2019


russell.gallop added inline comments.


================
Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:834
   if (LLVM_ENABLE_IR_PGO OR uppercase_LLVM_BUILD_INSTRUMENTED STREQUAL "IR")
     append("-fprofile-generate='${LLVM_PROFILE_DATA_DIR}'"
       CMAKE_CXX_FLAGS
----------------
smeenai wrote:
> Do you want to modify this as well?
Ah! I thought that these options weren't supported by clang-cl. Looks like Hans has fixed that in r357255. I'll change these as well. Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62063/new/

https://reviews.llvm.org/D62063





More information about the llvm-commits mailing list