[PATCH] D62145: [AArch64][SVE2] Asm: add PMULLB/PMULLT instructions

Tue May 21 01:45:21 PDT 2019

SjoerdMeijer added inline comments.

================
Comment at: test/MC/AArch64/SVE2/pmullb-128.s:3
+// RUN:        | FileCheck %s --check-prefixes=CHECK-ENCODING,CHECK-INST
+// RUN: not llvm-mc -triple=aarch64 -show-encoding < %s 2>&1 \
+// RUN:        | FileCheck %s --check-prefix=CHECK-ERROR
----------------
c-rhodes wrote:
> SjoerdMeijer wrote:
> > More explicit would be to add `-mattr=-sve2-aes` here.
> > But I guess it doesn't matter much, and to be consistent other tests would need updating too, e.g. `-mattr=-sve2` would need to be added to CHECK-ERROR tests in other files.
> > 
> That's a good point, I followed the approach taken for SVE in writing these tests and the feature isn't explicitly disabled there either. As you say, the other tests will also need updating and that is quite a large change, how about I create a patch for that and put it up once all the instructions are merged?
Yep, that sounds like a plan. But it's definitely a nitpick, and as it's a large change, leaving it as is would be okay I think. But if you don't mind changing it, that's fine too of course.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62145/new/

https://reviews.llvm.org/D62145