[PATCH] D62145: [AArch64][SVE2] Asm: add PMULLB/PMULLT instructions

Tue May 21 01:28:52 PDT 2019

SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.

LGTM

================
Comment at: test/MC/AArch64/SVE2/pmullb-128.s:3
+// RUN:        | FileCheck %s --check-prefixes=CHECK-ENCODING,CHECK-INST
+// RUN: not llvm-mc -triple=aarch64 -show-encoding < %s 2>&1 \
+// RUN:        | FileCheck %s --check-prefix=CHECK-ERROR
----------------
More explicit would be to add `-mattr=-sve2-aes` here.
But I guess it doesn't matter much, and to be consistent other tests would need updating too, e.g. `-mattr=-sve2` would need to be added to CHECK-ERROR tests in other files.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62145/new/

https://reviews.llvm.org/D62145