[PATCH] D62177: [ELF] Don't advance position in a memory region when assigning to the Dot

[Fangrui Song via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL361228: [ELF] Don't advance position in a memory region when assigning to the Dot (authored by MaskRay, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D62177?vs=200418&id=200422#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62177/new/

https://reviews.llvm.org/D62177

Files:
  lld/trunk/ELF/LinkerScript.cpp
  lld/trunk/test/ELF/linkerscript/memory5.test


Index: lld/trunk/ELF/LinkerScript.cpp
===================================================================
--- lld/trunk/ELF/LinkerScript.cpp
+++ lld/trunk/ELF/LinkerScript.cpp
@@ -135,8 +135,6 @@
   // Update to location counter means update to section size.
   if (InSec)
     expandOutputSection(Val - Dot);
-  else if (Val > Dot)
-    expandMemoryRegions(Val - Dot);
 
   Dot = Val;
 }
Index: lld/trunk/test/ELF/linkerscript/memory5.test
===================================================================
--- lld/trunk/test/ELF/linkerscript/memory5.test
+++ lld/trunk/test/ELF/linkerscript/memory5.test
@@ -5,9 +5,9 @@
 # RUN: llvm-objdump -section-headers %t.so | FileCheck %s
 
 # CHECK:      1 .text         00000001 0000000000042000
-# CHECK-NEXT: 2 .data         00000001 0000000000044001
+# CHECK-NEXT: 2 .data         00000001 0000000000042001
 
-## Test that assign to Dot changes the position in a memory region.
+## Test that assigning to Dot does not change the position in a memory region.
 
 MEMORY {
   ram (wxa) : ORIGIN = 0x42000, LENGTH = 0x100000


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62177.200422.patch
Type: text/x-patch
Size: 1069 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190521/9e7007e4/attachment.bin>