[PATCH] D62170: Add --reproduce to lld/wasm.

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

Few cosmetic issues I noticed are below.



================
Comment at: lld/wasm/Driver.cpp:31
+#include "llvm/Support/TarWriter.h"
 #include "llvm/Support/TargetSelect.h"
 
----------------
Unsorted.


================
Comment at: lld/wasm/Driver.cpp:555
 
+  // Handle --reprodue
+  if (auto *Arg = Args.getLastArg(OPT_reproduce)) {
----------------
`--reproduce`


================
Comment at: lld/wasm/InputFiles.cpp:35
 Optional<MemoryBufferRef> lld::wasm::readFile(StringRef Path) {
   log("Loading: " + Path);
 
----------------
Seems `Loading` should be lower case for conistency with `log` in `dumpInfo()` below.


================
Comment at: lld/wasm/InputFiles.h:36
 
+// If -reproduce option is given, all input files are written
+// to this tar archive.
----------------
Use double dashes for consistency with the other comments?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62170/new/

https://reviews.llvm.org/D62170