[PATCH] D62123: [NFC] SimplifyCFG prof branch_weighs handling is simplified

Yevgeny Rouban via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 21 00:03:53 PDT 2019


yrouban added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:3632
+    auto W0 = SIW.getSuccessorWeight(0);
+    SwitchInstProfBranchWeightsWrapper::CaseWeightOpt NewW;
+    if (W0) {
----------------
davidxl wrote:
> Perhaps add a 'SplitDefault' method in SwitchInstProfBranchWeightsWrapper class?
I think it does not look like a frequently used routine which is worth a separate method.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62123/new/

https://reviews.llvm.org/D62123





More information about the llvm-commits mailing list